Unit advance and stats changing - [SOLVED].

[ChaosRider]

How can I stop unit advancing from changing back (set to normal) unit stats like resistances, hp, or weapon dmg/strikes when i dont use object tags and i cant use:

Code: Select all

duration=forever

Im changing these stats inside stored unit which is later unstored as a copy from first one. Everything is fine besides that strikes/dmgs/resistances goes back as in original unit.

[zookeeper]

If you really can't use an [object], then I'm afraid you just have to re-apply the stats changes after advancement.

[ChaosRider]

I would like to use object tags but somehow used from unit stats values aint working inside code thx what while cant be stopped :/... quick little description before you see the code, main idea is that to decrease weapon strikes number and damages if this two things multiply together are higher than 150, if they are I set new max which is 75% of strikes*dmg value (later i check is this 75% is higher than 150, if not then max is again 150). When its lower i dont change weapon value.

Spoiler:

Code: Select all

																[store_unit]
																	[filter]
																		x,y=$Funny_Bonus_$SomeI3|_X,$Funny_Bonus_$SomeI3|_Y
																		#higher we have x,y created by other part of code in which I chose were to set label with copy unit text at turn start and there I do it in turn end 
																	[/filter]
																	variable=units_to_copy
																	kill=no
																[/store_unit]	
																{VARIABLE_OP units_to_copy.canrecruit value 0}
																[if]
																	[variable]
																		name=units_to_copy.max_hitpoints
																		greater_than=30
																	[/variable]
																	[then]
																		{VARIABLE_OP units_to_copy.hitpoints multiply "0.9"}
																		{VARIABLE_OP units_to_copy.max_hitpoints multiply "0.9"}
																	[/then]
																[/if]
																[if]
																	[variable]
																		name=units_to_copy.max_moves
																		greater_than=4
																	[/variable]
																	[then]
																		{VARIABLE_OP units_to_copy.moves multiply "0.9"}
																		{VARIABLE_OP units_to_copy.max_moves multiply "0.9"}
																	[/then]
																[/if]
																[if]
																	[variable]
																		name=units_to_copy.max_experience
																		less_than=150
																	[/variable]
																	[then]
																		{VARIABLE_OP units_to_copy.max_experience multiply "1.1"}
																	[/then]
																[/if]
																							
																{FOREACH units_to_copy.attack j}
																	{VARIABLE wdmbsvm 150}
																	# wdmbsvm = weapon damage multiply by strikes value max
																	{VARIABLE wdmbsvm2 $wdmbsvm}
																	# wdmbsvm = weapon damage multiply by strikes value max 2
																	{VARIABLE wdmbsv $units_to_copy.attack[$j].damage}
																	# wdmbsv = weapon damage multiply by strikes value
																	# Its no diffrence for me is unit will have 10-4 or 20-4 weapon, 
																	# as long strikes number multiply by damage is lower than 150, 
																	# if its bigger then we change weapon strikes damage & strikes
																	# also we change that 150 value for 75% of what unit weapon have now (dmg multiply by strikes number)
																	# later we check is this 75% is bigger than 150, if its not then max is changed for 150 back
																	{VARIABLE_OP wdmbsv multiply $units_to_copy.attack[$j].number}
																	[if]
																		[variable]
																			name=wdmbsv
																			greater_than=$wdmbsvm
																		[/variable]
																		[then]
																			{VARIABLE_OP wdmbsvm value $wdmbsv}
																			{VARIABLE_OP wdmbsvm multiply "0.75"}
																			[if]
																				[variable]
																					name=wdmbsvm
																					less_than=$wdmbsvm2
																				[/variable]
																				[then]
																					{VARIABLE_OP wdmbsvm value $wdmbsvm2}
																				[/then]
																			[/if]
																		[/then]
																	[/if]
																	#when we set max value for damages multiply by strikes then we start changing weapons which unit have
																	[while]
																		[variable]
																			name=wdmbsv
																			greater_than=$wdmbsvm
																		[/variable]
																		[do]
																			{VARIABLE_OP wdmbsvr rand (1,1,1,2)}
																			# wdmbsv = weapon damage multiply by strikes value random - by this value we know are we gonna change damages (75%), or strikes (25%)
																			[if]
																				[variable]
																					name=units_to_copy.attack[$j].number
																					less_than_equal_to=1
																				[/variable]
																				[then]
																					{VARIABLE_OP wdmbsvr value 1}
																					[while]
																						[variable]
																							name=units_to_copy.attack[$j].number
																							less_than=1
																						[/variable]
																						[do]
																							#just to be sure we dont have minus or 0 values in strikes number
																							[object]
																								silent=yes
																								duration=forever
																								[filter]
																									id=$units_to_copy.id
																								[/filter]
																								[effect]
																									apply_to=attack
																									name=$units_to_copy.attack[$j].name
																									range=$units_to_copy.attack[$j].range
																									increase_attacks=1
																								[/effect]
																							[/object]
																						[/do]
																					[/while]
																				[/then]
																			[/if]
																			[if]
																				[variable]
																					name=units_to_copy.attack[$j].damage
																					less_than_equal_to=1
																				[/variable]
																				[then]
																					{VARIABLE_OP wdmbsvr value 2}
																					[while]
																						[variable]
																							name=units_to_copy.attack[$j].damage
																							less_than=1
																						[/variable]
																						[do]
																							#just to be sure we dont have minus or 0 values in damages value
																							[object]
																								silent=yes
																								duration=forever
																								[filter]
																									id=$units_to_copy.id
																								[/filter]
																								[effect]
																									apply_to=attack
																									name=$units_to_copy.attack[$j].name
																									range=$units_to_copy.attack[$j].range
																									increase_damage=1
																								[/effect]
																							[/object]
																						[/do]
																					[/while]
																				[/then]
																			[/if]
																			[if]
																				[variable]
																					name=wdmbsvr
																					equals=1
																				[/variable]
																				[then]
																					{VARIABLE_OP wdmbsvr2 rand (5,4,4,3,3,3,2,2,2,2,2,2,1,1,1,1,1,1,1,1,1,1,1,1)}
																					#higher we just picked how much dmg we will decrease in unit weapon
																					#{VARIABLE_OP units_to_copy.attack[$j].damage sub $wdmbsvr2}
																					#with this higher unblocked it works, with this lower object tags somehow while cant be stopped cause lower bonus isnt added
																					[object]
																						silent=yes
																						duration=forever
																						[filter]
																							id=$units_to_copy.id
																						[/filter]
																						[effect]
																							apply_to=attack
																							name=$units_to_copy.weapon[$j].name
																							range=$units_to_copy.weapon[$j].range
																							increase_damage=-$wdmbsvr2
																						[/effect]
																					[/object]
																				[/then]
																				[else]
																					#{VARIABLE_OP units_to_copy.attack[$j].number sub 1}
																					#with this higher unblocked it works, with this lower object tags somehow while cant be stopped 
																					#because lower bonus isnt added so our weapon dmg * strikes cant be lower than 75% max
																					#because values of strike and dmgs dont change when loop works
																					[object]
																						silent=yes
																						duration=forever
																						[filter]
																							id=$units_to_copy.id
																						[/filter]
																						[effect]
																							apply_to=attack
																							name=$units_to_copy.weapon[$j].name
																							range=$units_to_copy.weapon[$j].range
																							increase_attacks=-1
																						[/effect]
																					[/object]
																				[/else]
																			[/if]
																			{VARIABLE wdmbsv $units_to_copy.attack[$j].damage}
																			{VARIABLE_OP wdmbsv multiply $units_to_copy.attack[$j].number}
																		[/do]
																	[/while]
																{NEXT j}
																{CLEAR_VARIABLE wdmbsv,wdmbsvm,wdmbsvm2,wdmbsvr,wdmbsvr2}

[Dugi]

The changes you make via variables and apply via unstore_unit are called soft changes. They are removed when a unit changes type (not necessarily when it advances) or an object expires. I am using these changes a lot and over time, I have figured out a reliable way to work with them.

How can it be done:
1. Make up some custom [effect]s that don't normally work. For example if we wanted to make sure that a unit will not deal more than 20 damage, it would be something like:

Code: Select all

[effect]
  apply_to=limit damage
  maximum=20
[/effect]

2. The above obviously does nothing, but it stays inside the unit where it should, regardless of the number of advancements. Add it via an [object] anyway.
3. Now, make an event you fire on the unit when it advances. It reads through all [object]s the unit has in modifications, checks its [effect]s and if it finds your new effect, it will perform the change. For example (this will make that limit damage thing working):

Code: Select all

[event]
  name=post advance
  first_time_only=no
  id=fix limit damage
  {VARIABLE damage_limit 9000}
  {FOREACH unit.modification.object i}
    {FOREACH unit.modification.object[$i].effect j}
      [if]
        [variable]
          name=unit.modification.object[$i].effect[$j].apply_to
          equals=limit damage
        [/variable]
        [then]
          {VARIABLE damage_limit $unit.modification.object[$i].effect[$j].maximum}
        [/then]
      [/if]
    {NEXT j}
  {NEXT i}
  {FOREACH unit.attack i}
    [if]
      [variable]
        name=unit.attack[$i].damage
        greater_than=$damage_limit
      [/variable]
      [then]
        {VARIABLE unit.attack[$i].damage $damage_limit}
      [/then]
    [/if]
  {NEXT i}
  {CLEAR_VARIABLE damage_limit}
  [unstore_unit]
    variable=unit
    find_vacant=no
  [/unstore_unit]
[/event]

Note that I haven't tested this, it was just meant to give you an idea what it is.

[ChaosRider]

Setting maximum limit damage for unit and using it by whole campaign wont be good option (I want to use it only when clone is creating first time, after whole that situation he should be allowed to increase own weapon dmg), when it can change in each turn. I changed a bit code, but still effects in object tags dont change unit weapon damages/strikes number thx what while loop cant end.

Spoiler:

Code: Select all

#define CHECK_WEAPON_STATS VALUE
	[if]
		[variable]
			name=unitcurrentweaponwhichwecheck
			less_than_equal_to=$unitallweapons
		[/variable]
		[then]
			{VARIABLE max_value_of_weapon 150}
			{VARIABLE current_value_of_weapon "$units_to_copy.attack[{VALUE}].damage"}
			{VARIABLE_OP current_value_of_weapon multiply "$units_to_copy.attack[{VALUE}].number"}
			[if]
				[variable]
					name=current_value_of_weapon
					greater_than=$max_value_of_weapon
				[/variable]
				[then]
					{VARIABLE_OP max_value_of_weapon value $current_value_of_weapon}
					{VARIABLE_OP max_value_of_weapon multiply "0.75"}
					[if]
						[variable]
							name=max_value_of_weapon
							less_than=150
						[/variable]
						[then]
							{VARIABLE_OP max_value_of_weapon value 150}
						[/then]
					[/if]
				[/then]
			[/if]   
			[while]
				[variable]
					name=current_value_of_weapon
					greater_than=$max_value_of_weapon
				[/variable]
				[do]
					{VARIABLE_OP choose_minus_bonus rand (1,1,1,2)}
					[if]
						[variable]
						   name=units_to_copy.attack[{VALUE}].number
						   less_than_equal_to=1
						[/variable]
						[then]
						   {VARIABLE_OP choose_minus_bonus value 1}
						   [while]
							  [variable]
								 name=units_to_copy.attack[{VALUE}].number
								 less_than=1
							  [/variable]
							  [do]
								 [object]
									silent=yes
									duration=forever
									[filter]
									   id=$units_to_copy.id
									[/filter]
									[effect]
									   apply_to=attack
									   name=$units_to_copy.attack[{VALUE}].name
									   range=$units_to_copy.attack[{VALUE}].range
									   increase_attacks=1
									[/effect]
								 [/object]
							  [/do]
						   [/while]
						[/then]
					 [/if]
					 [if]
						[variable]
						   name=units_to_copy.attack[{VALUE}].damage
						   less_than_equal_to=1
						[/variable]
						[then]
						   {VARIABLE_OP choose_minus_bonus value 2}
						   [while]
							  [variable]
								 name=units_to_copy.attack[{VALUE}].damage
								 less_than=1
							  [/variable]
							  [do]
								 [object]
									silent=yes
									duration=forever
									[filter]
									   id=$units_to_copy.id
									[/filter]
									[effect]
									   apply_to=attack
									   name=$units_to_copy.attack[{VALUE}].name
									   range=$units_to_copy.attack[{VALUE}].range
									   increase_damage=1
									[/effect]
								 [/object]
							  [/do]
						   [/while]
						[/then]
					 [/if]
					 [if]
						[variable]
						   name=choose_minus_bonus
						   equals=1
						[/variable]
						[then]
							#{VARIABLE_OP units_to_copy.attack[{VALUE}].damage sub $choose_minus_bonus2}
							{VARIABLE_OP choose_minus_bonus2 rand (5,4,4,3,3,3,2,2,2,2,2,2,1,1,1,1,1,1,1,1,1,1,1,1)}
							[object]
								silent=yes
								duration=forever
								[filter]
									id=$units_to_copy.id
								[/filter]
								[effect]
									apply_to=attack
									name=$units_to_copy.attack[{VALUE}].name
									range=$units_to_copy.attack[{VALUE}].range
									increase_damage=-$choose_minus_bonus2
								[/effect]
							[/object]
						[/then]
						[else]
							#{VARIABLE_OP units_to_copy.attack[{VALUE}].number sub 1}
							[object]
								silent=yes
								duration=forever
								[filter]
									id=$units_to_copy.id
								[/filter]
								[effect]
									apply_to=attack
									name=$units_to_copy.attack[{VALUE}].name
									range=$units_to_copy.attack[{VALUE}].range
									increase_attacks=-1
								[/effect]
							[/object]
						[/else]
					 [/if]
					 {VARIABLE current_value_of_weapon $units_to_copy.attack[{VALUE}].damage}
					 {VARIABLE_OP current_value_of_weapon multiply $units_to_copy.attack[{VALUE}].number}
				[/do]
			[/while]
			{VARIABLE_OP unitcurrentweaponwhichwecheck add 1}	
		[/then]
	[/if]
#enddef

Spoiler:

Code: Select all

																[store_unit]
																   [filter]
																	  x,y=$Funny_Bonus_$SomeI3|_X,$Funny_Bonus_$SomeI3|_Y
																   [/filter]
																   variable=units_to_copy
																   kill=no
																[/store_unit]   
																#{MODIFY_UNIT id=units_to_copy.id variables.unit_clone "yes"}	
																
																{VARIABLE_OP units_to_copy.canrecruit value 0}
																{VARIABLE_OP units_to_copy.variables.unit_clone value "yes"}
																[unstore_unit]
																	variable=units_to_copy
																	find_vacant=yes
																	check_passability=no
																[/unstore_unit]
																{CLEAR_VARIABLE units_to_copy}
																
																[store_unit]
																   [filter]
																		[filter_wml]
																			[variables]
																				unit_clone="yes"
																			[/variables]
																		[/filter_wml]
																   [/filter]
																   variable=units_to_copy
																   kill=no
																[/store_unit]   
																{VARIABLE unitallweapons -1}							
																{FOREACH units_to_copy.attack z}														
																	{VARIABLE_OP unitallweapons add 1}
																{NEXT z}	
																{VARIABLE unitcurrentweaponwhichwecheck 0}
																
																{CHECK_WEAPON_STATS 0}
																{CHECK_WEAPON_STATS 1}
																{CHECK_WEAPON_STATS 2}
																{CHECK_WEAPON_STATS 3}
																{CHECK_WEAPON_STATS 4}
																{CHECK_WEAPON_STATS 5}
																{CHECK_WEAPON_STATS 6}
																{CHECK_WEAPON_STATS 7}
																{CHECK_WEAPON_STATS 8}
																{CHECK_WEAPON_STATS 9}
																{CHECK_WEAPON_STATS 10}
																{CHECK_WEAPON_STATS 11}
																{CHECK_WEAPON_STATS 12}
																{CHECK_WEAPON_STATS 13}
																{CHECK_WEAPON_STATS 14}

																{CLEAR_VARIABLE current_value_of_weapon,max_value_of_weapon,choose_minus_bonus,choose_minus_bonus2}	
																{CLEAR_VARIABLE units_to_copy.underlying_id,units_to_copy.id,units_to_copy.variables.unit_clone}	
																
																[unstore_unit]
																	variable=units_to_copy
																	find_vacant=no
																[/unstore_unit]
																{CLEAR_VARIABLE units_to_copy}

Below are parts of define "CHECK_WEAPON_STATS VALUE" which dont change unit weapon stats when it should works.

Spoiler:

Code: Select all

						[then]
							#{VARIABLE_OP units_to_copy.attack[{VALUE}].damage sub $choose_minus_bonus2}
							{VARIABLE_OP choose_minus_bonus2 rand (5,4,4,3,3,3,2,2,2,2,2,2,1,1,1,1,1,1,1,1,1,1,1,1)}
							[object]
								silent=yes
								duration=forever
								[filter]
									id=$units_to_copy.id
								[/filter]
								[effect]
									apply_to=attack
									name=$units_to_copy.attack[{VALUE}].name
									range=$units_to_copy.attack[{VALUE}].range
									increase_damage=-$choose_minus_bonus2
								[/effect]
							[/object]
						[/then]
						[else]
							#{VARIABLE_OP units_to_copy.attack[{VALUE}].number sub 1}
							[object]
								silent=yes
								duration=forever
								[filter]
									id=$units_to_copy.id
								[/filter]
								[effect]
									apply_to=attack
									name=$units_to_copy.attack[{VALUE}].name
									range=$units_to_copy.attack[{VALUE}].range
									increase_attacks=-1
								[/effect]
							[/object]
						[/else]

[Dugi]

Code: Select all

                                                {CHECK_WEAPON_STATS 0}
                                                {CHECK_WEAPON_STATS 1}
                                                {CHECK_WEAPON_STATS 2}
                                                {CHECK_WEAPON_STATS 3}
                                                {CHECK_WEAPON_STATS 4}
                                                {CHECK_WEAPON_STATS 5}
                                                {CHECK_WEAPON_STATS 6}
                                                {CHECK_WEAPON_STATS 7}
                                                {CHECK_WEAPON_STATS 8}
                                                {CHECK_WEAPON_STATS 9}
                                                {CHECK_WEAPON_STATS 10}
                                                {CHECK_WEAPON_STATS 11}
                                                {CHECK_WEAPON_STATS 12}
                                                {CHECK_WEAPON_STATS 13}
                                                {CHECK_WEAPON_STATS 14}

Why don't you just write:

Code: Select all

{FOREACH units_to_copy.attack i}
  {CHECK_WEAPON_STATS $i}
{NEXT i}

The code is shorter when seen and SIGNIFICANTLY shorter when loaded with macros replaced. Faster loading, less RAM usage, no drawbacks at all!

[ChaosRider]

Form of code was changed a lot, so was a time when I had it in one FOREACH as you written it higher, but its still same, effect tags don't change unit weapon stats - which is important to exit from while loop. Im using here twice storing to first just create copy, and later I store only copied unit (if I do it in one store then all changes from effect tags will be added to original which is bad) to change it stats.

Other idea which i have for now is to let 2 units (original and copy) have a same id for a moment, thx what later I will be able to find this unit (copied one) with this id but with diffrent x,y than its set for a bonus hex (cause i cant say where its will be spawned).

[Dugi]

My method IS working, I am using it like everywhere in my campaign and almost none of its items would work without it. If you can't get it to work, you are doing it wrong.

First, familiarise yourself with the code I proposed. Make a unit, apply that object on it and fire the post advance event on it. See that it has an effect. Have it advance and you'll see that the effect persists. Then, start experimenting with it until you edit it into the form you desire. You absolutely don't need to copy the unit.

effect tags don't change unit weapon stats

That isn't supposed to do that. The effect I proposed does nothing, it is just a mark for the post advance event to know what it should do. The mark remains regardless of the number of level-ups and the event will recreate the effect every time.

Other idea which i have for now is to let 2 units (original and copy) have a same id for a moment

This will not work. Two units with the same id can't live together, one of them will suddenly disappear shortly afterwards.

[ChaosRider]

My method IS working, I am using it like everywhere in my campaign and almost none of its items would work without it. If you can't get it to work, you are doing it wrong.

That "bonus" which is coping unit i dont want to make it threat as an item, also i dont want allow copied one to drop his decreased stats of weapons which he was using while coping (after copy him he can get new weapon later, who knows what will happen) and go back to normal one as in original unit.

First, familiarise yourself with the code I proposed. Make a unit, apply that object on it and fire the post advance event on it. See that it has an effect. Have it advance and you'll see that the effect persists. Then, start experimenting with it until you edit it into the form you desire. You absolutely don't need to copy the unit.

Your setting limits for weapon damages which are used by whole game can disturb other bonuses which can increase weapon stats. Its not a good path as for me, also my code is working when im using as you said "soft changes" when its right time:

Spoiler:

Code: Select all

{VARIABLE_OP choose_minus_bonus2 rand (5,4,4,3,3,3,2,2,2,2,2,2,1,1,1,1,1,1,1,1,1,1,1,1)}
					 #{VARIABLE_OP units_to_copy2[$i].attack[$j].damage sub $choose_minus_bonus2}

as this line higher posted & blocked by hash this below should works same (but its not thx what my code isnt working, cant leave while loop)

Spoiler:

Code: Select all

					 [object]
					   [filter]
						   id=$units_to_copy2[$i].id
					   [/filter]
					   silent=yes
					   duration=forever
					   [effect]
						   apply_to=attack
						   name="$units_to_copy2[$i].attack[$j].name"
						   range="$units_to_copy2[$i].attack[$j].range"
						   increase_damage=-$choose_minus_bonus2
						[/effect]
					 [/object]

I need to use it in effect tags to solve problem with unit advancing, so I dont know why something what i used already in other codes isnt working here. Diffrence is that Im changing copy of the unit, which is already spawned on map (earlier version of this code has been split for 2 smaller parts), and not the original unit as in other codes which i made already.

I have already require for me variables and values so I need to know how it should be properly written in effect tags.

Below are parts of code:
Code to copy unit (works)

Spoiler:

Code: Select all

																[store_unit]
																   [filter]
																	 x,y=$Funny_Bonus_$SomeI3|_X,$Funny_Bonus_$SomeI3|_Y
																   [/filter]
																   variable=units_to_copy
																   kill=no
																[/store_unit]    
																
																{VARIABLE_OP units_to_copy.variables.unit_clone value "yes"}
																{CLEAR_VARIABLE units_to_copy2.underlying_id,units_to_copy2.id}    
																{VARIABLE_OP units_to_copy.canrecruit value 0}
																[unstore_unit]
																   variable=units_to_copy
																   find_vacant=yes
																   check_passability=no
																[/unstore_unit]
																{CLEAR_VARIABLE units_to_copy}
																
																{VARIABLE_OP some_another_mystic_value_for_while add 1}

Code to find & change copied units (not works, reason is higher posted)

Spoiler:

Code: Select all

	[event]
		name=turn end
		first_time_only=no
		id=Funny_Bonus_Change_Clones_Weapons_Stats	
		[if]
			[variable]
				name=Do_We_Do_Funny_Bonuses
				equals=0
			[/variable]
			[then]
				[store_unit]
				   [filter]
						[filter_wml]
							[variables]
								unit_clone="yes"
							[/variables]
						[/filter_wml]
				   [/filter]
				   variable=units_to_copy2
				   kill=no
				[/store_unit]   
				{FOREACH units_to_copy2 i}
					[message]
						speaker=narrator
						message= _ "Im inside loop of stored copies with number $i."
					[/message]
					{VARIABLE_OP units_to_copy2[$i].canrecruit value 0}
					{VARIABLE_OP units_to_copy2[$i].hitpoints multiply "0.9"}
					{VARIABLE_OP units_to_copy2[$i].max_hitpoints multiply "0.9"}
					{VARIABLE_OP units_to_copy2[$i].moves multiply "0.9"}
					{VARIABLE_OP units_to_copy2[$i].max_moves multiply "0.9"}
					{VARIABLE_OP units_to_copy2[$i].max_experience multiply "1.1"}
					
					{CHECK_WEAPON_STATS}

					{CLEAR_VARIABLE current_value_of_weapon,max_value_of_weapon,choose_minus_bonus,choose_minus_bonus2,units_to_copy2[$i].variables.unit_clone}   
					
					[unstore_unit]
					   variable=units_to_copy2[$i]
					   find_vacant=no
					[/unstore_unit]
				{NEXT i}
				{CLEAR_VARIABLE units_to_copy2}
			[/then]
		[/if]
	[/event]

Spoiler:

Code: Select all

#define CHECK_WEAPON_STATS			
	{FOREACH units_to_copy2[$i].attack j}
		[message]
			speaker=narrator
			message= _ "Im inside loop of stored copies weapons with number $j."
		[/message]
		 {VARIABLE max_value_of_weapon 150}
		 {VARIABLE current_value_of_weapon "$units_to_copy2[$i].attack[$j].damage"}
		 {VARIABLE_OP current_value_of_weapon multiply "$units_to_copy2[$i].attack[$j].number"}
		 [if]
			[variable]
			   name=current_value_of_weapon
			   greater_than=$max_value_of_weapon
			[/variable]
			[then]
			   {VARIABLE_OP max_value_of_weapon value $current_value_of_weapon}
			   {VARIABLE_OP max_value_of_weapon multiply "0.75"}
			   [if]
				  [variable]
					 name=max_value_of_weapon
					 less_than=150
				  [/variable]
				  [then]
					 {VARIABLE_OP max_value_of_weapon value 150}
				  [/then]
			   [/if]
			[/then]
		 [/if]   
		 [while]
			[variable]
			   name=current_value_of_weapon
			   greater_than=$max_value_of_weapon
			[/variable]
			[do]
				[message]
					speaker=narrator
					message= _ "Im inside loop of weapons - loop 1."
				[/message]
			   {VARIABLE_OP choose_minus_bonus rand (1,1,1,2)}
			   [if]
				  [variable]
					 name=units_to_copy2[$i].attack[$j].number
					 less_than_equal_to=1
				  [/variable]
				  [then]
					 {VARIABLE_OP choose_minus_bonus value 1}
					 [while]
					   [variable]
						 name=units_to_copy2[$i].attack[$j].number
						 less_than=1
					   [/variable]
					   [do]
						[message]
							speaker=narrator
							message= _ "Im inside loop of weapons - loop 2."
						[/message]
						 [object]
						   [filter]
							   id=$units_to_copy2[$i].id
						   [/filter]
						   silent=yes
						   duration=forever
						   [effect]
							  apply_to=attack
							  name="$units_to_copy2[$i].attack[$j].name"
							  range="$units_to_copy2[$i].attack[$j].range"
							  increase_attacks=1
						   [/effect]
						[/object]
					   [/do]
					 [/while]
				  [/then]
				[/if]
				[if]
				  [variable]
					 name=units_to_copy2[$i].attack[$j].damage
					 less_than_equal_to=1
				  [/variable]
				  [then]
					 {VARIABLE_OP choose_minus_bonus value 2}
					 [while]
					   [variable]
						 name=units_to_copy2[$i].attack[$j].damage
						 less_than=1
					   [/variable]
					   [do]
						[message]
							speaker=narrator
							message= _ "Im inside loop of weapons - loop 3."
						[/message]
						 [object]
						   [filter]
							   id=$units_to_copy2[$i].id
						   [/filter]
						   silent=yes
						   duration=forever
						   [effect]
							  apply_to=attack
							  name="$units_to_copy2[$i].attack[$j].name"
							  range="$units_to_copy2[$i].attack[$j].range"
							  increase_damage=1
						   [/effect]
						 [/object]
					   [/do]
					 [/while]
				  [/then]
				[/if]
				[if]
				  [variable]
					 name=choose_minus_bonus
					 equals=1
				  [/variable]
				  [then]
					 {VARIABLE_OP choose_minus_bonus2 rand (5,4,4,3,3,3,2,2,2,2,2,2,1,1,1,1,1,1,1,1,1,1,1,1)}
					 #{VARIABLE_OP units_to_copy2[$i].attack[$j].damage sub $choose_minus_bonus2}
					[message]
						speaker=narrator
						message= _ "Im inside loop of weapons - we picked to decrease damages - weapon $j
Weapon name: $units_to_copy2[$i].attack[$j].name
Weapon range: $units_to_copy2[$i].attack[$j].range|."
					[/message]
					 [object]
					   [filter]
						   id=$units_to_copy2[$i].id
					   [/filter]
					   silent=yes
					   duration=forever
					   [effect]
						   apply_to=attack
						   name="$units_to_copy2[$i].attack[$j].name"
						   range="$units_to_copy2[$i].attack[$j].range"
						   increase_damage=-$choose_minus_bonus2
						[/effect]
					 [/object]
				  [/then]
				  [else]
					 #{VARIABLE_OP units_to_copy2[$i].attack[$j].number sub 1}
					[message]
						speaker=narrator
						message= _ "Im inside loop of weapons - we picked to decrease strikes - weapon $j
Weapon name: $units_to_copy2[$i].attack[$j].name
Weapon range: $units_to_copy2[$i].attack[$j].range|."
					[/message]
					 [object]
					   [filter]
						   id=$units_to_copy2[$i].id
					   [/filter]
					   silent=yes
					   duration=forever
					   [effect]
						   apply_to=attack
						   name="$units_to_copy2[$i].attack[$j].name"
						   range="$units_to_copy2[$i].attack[$j].range"
						   increase_attacks=-1
						[/effect]
					 [/object]
				  [/else]
				[/if]
				{VARIABLE current_value_of_weapon $units_to_copy2[$i].attack[$j].damage}
				{VARIABLE_OP current_value_of_weapon multiply $units_to_copy2[$i].attack[$j].number}
			[/do]
		 [/while] 
	{NEXT j}
#enddef

In this code you have also set messages to appear which helps to know whats going on and in which place.

I can use it with "soft changes" but copied units which don't use yet own last form will get back stats (hp,mp,xp max, weapons stats) as in original one (which differs from my idea to make copies weaker than original unit).

Edit 2: Also if some admins is watching it I have to say that at Wesnoth Wiki is no info about how to carry these "soft changes" made by wml between unit forms while its advancing to higher lvl.

[Dugi]

That "bonus" which is coping unit i dont want to make it threat as an item, also i dont want allow copied one to drop his decreased stats of weapons which he was using while coping (after copy him he can get new weapon later, who knows what will happen) and go back to normal one as in original unit.

So you can just set it as a variable. If you have problems with using [object], you can just set a variable into it, for example unit.variables.damage_limit to 20 and you have it working too. I just found the objects more convenient. The point is that you have to mark somehow that the change was done and that it has to be done again when it advances. If the order of changes troubles you, you have no other options than to create an object specially tailored for that change and apply it.

Your setting limits for weapon damages which are used by whole game can disturb other bonuses which can increase weapon stats.

Have you really read what I wrote? I told you that it's just an example. Get it working first to understand properly how is it supposed to work, then change it so that it would suit you.

[ChaosRider]

Thx that I created this topic I tried other options with post_advance (thx Dugi idea), but this wasnt enought since units default weapons (which they have from the beginning of own existence) may change weapon name while advancing (as 1 lvl ghost which touch is changing in to baneblade at 2 lvl).
That changing of their names may cause some bug when copied unit which sold default weapon after advance get it back with diffrent name and also without any minus bonuses (because it hadn't it before advance).
Other situation in which it may fail is that when weapon after advance change own name & place in weapons list.
Another one is when while coping hadn't weapon which it get after advance - it works only for weapons which unit had while coping.

Other information which I deduced during of writing this code:

Spoiler:

In Wesnoth 1.10.
Using MODIFY_UNIT in advance event makes unit advance before your event ends (so you can't use it there).

Any changing of unit variables without using MODIFY_UNIT won't work in event with name=advance.

Effect/object tags don't works at copied unit in same event when its coping, they are added to original one.

My code is immune for changing weapon place at weapons list (when its not changing also name!) in unit.
I don't know is it cause oos, its not tested in mp game.
If no one will do that funny bug about which I wrote higher then weapon which is changing name after advance also will get minus bonuses which copied unit had from being copied.

end turn 1 event - when we copy unit

Spoiler:

Code: Select all

																[store_unit]
																   [filter]
																	 x,y=$Funny_Bonus_$SomeI3|_X,$Funny_Bonus_$SomeI3|_Y
																   [/filter]
																   variable=units_to_copy
																   kill=no
																[/store_unit]    
																
																{VARIABLE_OP units_to_copy.variables.unit_clone value "yes"}
																{CLEAR_VARIABLE units_to_copy2.underlying_id,units_to_copy2.id}    
																{VARIABLE_OP units_to_copy.canrecruit value 0}
																[unstore_unit]
																   variable=units_to_copy
																   find_vacant=yes
																   check_passability=no
																[/unstore_unit]
																{CLEAR_VARIABLE units_to_copy}

end turn 2nd event - when its copied already and we change weapons

Spoiler:

Code: Select all

	[event]
		name=turn end
		first_time_only=no
		id=Funny_Bonus_Change_Clones_Weapons_Stats	
		[if]
			[variable]
				name=Do_We_Do_Funny_Bonuses
				equals=0
			[/variable]
			[then]
				[store_unit]
				   [filter]
						[filter_wml]
							[variables]
								unit_clone="yes"
							[/variables]
						[/filter_wml]
				   [/filter]
				   variable=units_to_copy2
				   kill=no
				[/store_unit]   
				{FOREACH units_to_copy2 i}
					
					{CHECK_WEAPON_STATS}

					{CLEAR_VARIABLE current_value_of_weapon,max_value_of_weapon,choose_minus_bonus,choose_minus_bonus2,units_to_copy2[$i].variables.unit_clone}   
					
					[unstore_unit]
					   variable=units_to_copy2[$i]
					   find_vacant=no
					[/unstore_unit]
				{NEXT i}
				{CLEAR_VARIABLE units_to_copy2}
			[/then]
		[/if]
	[/event]

advance event - we check what weapons we have (its done like this to make it works also for weapons which changed own name or place in weapons list in unit after advance) at unit before advance

Spoiler:

Code: Select all

	[event]
		name=advance
		first_time_only=no
		id=Funny_Bonus_Change_Clones_Weapons_Stats2	
		[store_unit]
			[filter]
				x,y=$unit.x,$unit.y
				[filter_wml]
					[variables]
						minus_bonus_got="yes"
					[/variables]
				[/filter_wml]
			[/filter]
			variable=before_advance
		[/store_unit]
		{VARIABLE real 0}
		{VARIABLE real2 0}
		{VARIABLE idofadvancingunit $before_advance.id}
		[while]
			[variable]
				name=before_advance.variables.weapon_minus_bonus_name_$real
				not_equals=$null
			[/variable]
			[do]
				{FOREACH before_advance.attack i}
					[if]
						[variable]
							name=before_advance.attack[$i].name
							equals="$before_advance.variables.weapon_minus_bonus_name_$real"
						[/variable]
						[then]
							{VARIABLE_OP unitweaponname_$real2 value $before_advance.attack[$i].name}
							[if]
								[variable]
									name=before_advance.variables.weapon_minus_bonus_damage_$real
									not_equals=$null
								[/variable]
								[then]
									{VARIABLE_OP unitweapondamage_$real2 value $before_advance.variables.weapon_minus_bonus_damage_$real}
								[/then]
							[/if]
							[if]
								[variable]
									name=before_advance.variables.weapon_minus_bonus_strike_$real
									not_equals=$null
								[/variable]
								[then]
									{VARIABLE_OP unitweaponstrike_$real2 value $before_advance.variables.weapon_minus_bonus_strike_$real}
								[/then]
							[/if]
							{VARIABLE_OP real2 add 1}
						[/then]
					[/if]
				{NEXT i}
				{VARIABLE_OP real add 1}
			[/do]
		[/while]
		{CLEAR_VARIABLE real,real2,before_advance}
	[/event]

post advance event

Spoiler:

Code: Select all

	[event]
		name=post_advance
		first_time_only=no
		id=Funny_Bonus_Change_Clones_Weapons_Stats3	
		[store_unit]
			[filter]
				id=$idofadvancingunit
			[/filter]
			kill=no
			variable=just_advanced
		[/store_unit]
		{VARIABLE real 0}
		[while]
			[variable]
				name=unitweaponname_$real
				not_equals=$null
			[/variable]
			[do]
				{FOREACH just_advanced.attack i}
					[if]
						[variable]
							name=i
							equals=$real
						[/variable]
						[then]
							{VARIABLE_OP allweaponsarediffrent value 0}
							{FOREACH just_advanced.attack z}
								[if]
									[variable]
										name=unitweaponname_$real
										equals=$just_advanced.attack[$z].name
									[/variable]
									[then]
										{VARIABLE_OP allweaponsarediffrent value 1}
									[/then]
								[/if]
							{NEXT z}
							[if]
								[variable]
									name=unitweaponname_$real
									not_equals=$just_advanced.attack[$i].name
								[/variable]
								[and]
									[variable]
										name=allweaponsarediffrent
										not_equals=1
									[/variable]
								[/and]
								[then]
									{VARIABLE_OP unitweaponname_$real value $just_advanced.attack[$i].name}
									{MODIFY_UNIT id=$just_advanced.id variables.weapon_minus_bonus_name_$real $just_advanced.attack[$i].name}
									[if]
										[variable]
											name=unitweapondamage_$real
											not_equals=$null
										[/variable]
										[then]
											{MODIFY_UNIT id=$just_advanced.id variables.weapon_minus_bonus_damage_$real $unitweapondamage_$real}
											{VARIABLE_OP unitdamagefunnyone value $unitweapondamage_$real}
											[object]
												[filter]
													id=$just_advanced.id
												[/filter]
												silent=yes
												duration=forever
												[effect]
													apply_to=attack
													name="$just_advanced.attack[$i].name"
													range="$just_advanced.attack[$i].range"
													increase_damage=-$unitweapondamage_$real
												[/effect]
											[/object]
											{CLEAR_VARIABLE unitdamagefunnyone}
										[/then]
									[/if]
									[if]
										[variable]
											name=unitweaponstrike_$real
											not_equals=$null
										[/variable]
										[then]
											{MODIFY_UNIT id=$just_advanced.id variables.weapon_minus_bonus_strike_$real $$unitweaponstrike_$real}
											{VARIABLE_OP unitstrikefunnyone value $unitweaponstrike_$real}
											[object]
												[filter]
													id=$just_advanced.id
												[/filter]
												silent=yes
												duration=forever
												[effect]
													apply_to=attack
													name="$just_advanced.attack[$i].name"
													range="$just_advanced.attack[$i].range"
													increase_attacks=-$unitweaponstrike_$real
												[/effect]
											[/object]
											{CLEAR_VARIABLE unitstrikefunnyone}
										[/then]
									[/if]
								[/then]
								[else]
									[if]
										[variable]
											name=unitweapondamage_$real
											not_equals=$null
										[/variable]
										[and]
											[variable]
												name=just_advanced.variables.minus_bonus_got2
												not_equals="done"
											[/variable]
										[/and]
										[then]
											{MODIFY_UNIT id=$just_advanced.id variables.weapon_minus_bonus_strike_$real $$unitweaponstrike_$real}
											{VARIABLE_OP unitdamagefunnyone value $unitweapondamage_$real}
											[object]
												[filter]
													id=$just_advanced.id
												[/filter]
												silent=yes
												duration=forever
												[effect]
													apply_to=attack
													name="$just_advanced.attack[$i].name"
													range="$just_advanced.attack[$i].range"
													increase_damage=-$unitweapondamage_$real
												[/effect]
											[/object]
											{CLEAR_VARIABLE unitdamagefunnyone}
										[/then]
									[/if]
									[if]
										[variable]
											name=unitweaponstrike_$real
											not_equals=$null
										[/variable]
										[and]
											[variable]
												name=just_advanced.variables.minus_bonus_got2
												not_equals="done"
											[/variable]
										[/and]
										[then]
											{MODIFY_UNIT id=$just_advanced.id variables.weapon_minus_bonus_strike_$real $$unitweaponstrike_$real}
											{VARIABLE_OP unitstrikefunnyone value $unitweaponstrike_$real}
											[object]
												[filter]
													id=$just_advanced.id
												[/filter]
												silent=yes
												duration=forever
												[effect]
													apply_to=attack
													name="$just_advanced.attack[$i].name"
													range="$just_advanced.attack[$i].range"
													increase_attacks=-$unitweaponstrike_$real
												[/effect]
											[/object]
											{CLEAR_VARIABLE unitstrikefunnyone}
										[/then]
									[/if]
								[/else]
							[/if]
						[/then]
					[/if]
				{NEXT i}
				{VARIABLE_OP real add 1}
			[/do]
		[/while]
		{CLEAR_VARIABLE real,allweaponsarediffrent}
		[if]
			[variable]
				name=just_advanced.minus_bonus_got2
				not_equals=$done
			[/variable]
			[then]
				[if]
					[variable]
						name=just_advanced.variables.minus_bonus_moves
						not_equals=$null
					[/variable]
					[then]
						[object]
							duration=forever
							silent=yes
							[filter]
								id=$just_advanced.id
							[/filter]
							[effect]
								apply_to=movement
								increase=-$just_advanced.variables.minus_bonus_moves
							[/effect]
						[/object]
					[/then]
				[/if]
				[if]
					[variable]
						name=just_advanced.variables.minus_bonus_hitpoints
						not_equals=$null
					[/variable]
					[then]
						[object]
							duration=forever
							silent=yes
							[filter]
								id=$just_advanced.id
							[/filter]
							[effect]
								apply_to=hitpoints
								increase=-$just_advanced.variables.minus_bonus_hitpoints
								increase_total=-$just_advanced.variables.minus_bonus_hitpoints
							[/effect]
						[/object]
					[/then]
				[/if]
				[if]
					[variable]
						name=just_advanced.variables.minus_bonus_experience
						not_equals=$null
					[/variable]
					[then]
						[object]
							duration=forever
							silent=yes
							[filter]
								id=$just_advanced.id
							[/filter]
							[effect]
								apply_to=max_experience
								replace=no
								increase=$just_advanced.variables.minus_bonus_experience
							[/effect]
						[/object]
					[/then]
				[/if]
			[/then]
		[/if]
		{MODIFY_UNIT id=$just_advanced.id variables.minus_bonus_got2 done}
	[/event]

So I can say the problem is solved... in crazy way, but it is done.