Whispers.

Tomsik · Post by **Tomsik** » February 18th, 2006, 9:31 pm

Usage: /whisper [nick] [message]
Sends private message to [nick]

Right now it works only in lobby.

Note: Files are not whole files, they contain only changed parts, i marked what's exactly changed.

Website · Post by **Xan** » February 18th, 2006, 9:34 pm

Actually, you should probably just post the whole files, since a diff can be obtained really easily.

Tomsik · Post by **Tomsik** » February 18th, 2006, 9:40 pm

I have problems with accessing SVN, ("Malformed network data") so i'm not sure i have newest files. (last time i've updated it yesterday)

Post by **Boucman** » February 19th, 2006, 8:58 am

malformed network data happens when your trying to update while someone else is comitting...

tomsik, I'm looking at your code, but could you still post it on patches.wesnoth.org

we will keep this thread to discuss the actual content of the patch, it might be usefull for other people willing to contribute and wondering how to do it

I usually prefer receiving a diff, it's easier to me to apply and check

thx

Post by **Noyga** » February 19th, 2006, 9:09 am

Hmmm ... I would just change "/whisper" to "/msg"
"/msg" sounds more universal to me

Post by **Boucman** » February 19th, 2006, 10:32 am

I've already told that to TOmsik on IRC, but I'm repeating it here so other people see my comments and dont do the same mistakes

1) please use svn diff to do patches, it's easier for me to apply, and it saves the precise revision number you are using
2) always submit to patches.wesnoth.org, it allows me to keep track of the patch (posting here too for discussion is ok)
3) add a changelog entry in the patch, it avoids me doing it
4) add yourself to about.cfg if your not there yet

thx

Tomsik · Post by **Tomsik** » February 19th, 2006, 11:36 am

Submited on patches.wesnoth.org.
I've changed "/whisper" to "/msg".
Now you can send from/to lobby and as/to observer, but you can't send as/to player because especially in FFA it could make bad situations. (hidden aliances for example)

Post by **Boucman** » February 19th, 2006, 7:11 pm

slight problem... from the lobby you don't know who is a player and who is an observer...

Post by **Noyga** » February 19th, 2006, 9:08 pm

What about adding a small eye icon in front of observers names ?

Tomsik · Post by **Tomsik** » February 19th, 2006, 9:11 pm

Noyga wrote:What about adding a small eye icon in front of observers names ?

That's work for whole patch/commit i think.