Maybe... a Bug?

[Dret]

Hi to all...

I want to expose a strange situation that take effect using teleport feature.

I have a [set_menu_item] with possibility for player's leaders to "teleport" themself around the map.
Scenario is a 1 vs 1 battle (so we have only 2 players)

I used this code:

At first a MACRO to find the coordinates of side leader:

Code: Select all

#define FIND_COO_LEADERS SIDE VAR1 TO_VAR1 VAR2 TO_VAR2
    [store_unit]
        [filter]
			side={SIDE}
			canrecruit=yes
        [/filter]	
		
        kill=no
        variable=leader_pos
    [/store_unit]

    [set_variable]
        name={TO_VAR1}
        format=$leader_pos.{VAR1}
    [/set_variable]
    
        [set_variable]
        name={TO_VAR2}
        format=$leader_pos.{VAR2}
    [/set_variable]


    [clear_variable]
        name=leader_pos
    [/clear_variable]
#enddef

then the code to teleport unit.... into the new location:

Code: Select all

{FIND_COO_LEADERS $side_number x Lx y Ly}
	
 {TELEPORT_UNIT (x,y=$Lx,$Ly side=$side_number canrecruit=yes) $x1 $y1}	
{FLOATING_TEXT x,y=$x1,$y1 0,0,255 "BLINK!"}	

The teleport event works... PERFECTLY... but something strange happens when the leader unit is teleported over a village:

If Player 1 leader is teleported on an empty village this become... OWNED by ENEMY (player 2!)

If Player 2 leader is teleported on an empty village, this last remain the same... (not owned by any players!!)

Maybe a Wesnoth Bug...???!!!

Thanks!
Bye

[Sapient]

sounds like a bug

[Dret]

Do You suggest me to send a report to code developers...??

[Sapient]

yes, those silly "developer" people probably want to know about it

bugs.wesnoth.org

[Iris]

yes, those silly "developer" people...

Huh?

[Noyga]

It looks like a +/-1 offset somewhere in the C++ code (internal side number = WML & displayed side number -1 IIRC)...
Probably easy to fix (if it hasn't been fixed yet in SVN ).

[Noyga]

I fixed this bug, so it will be fixed in the next available scenarios.
Note that this might produce OOS error on scenarios that use [teleport] to a village with 1.4.3+ and 1.4.2- clients, anyway i'm not aware of any (and for this reason it might be reverted before 1.4.3 if other devs feel unconfortable with this minor incompatibility).