[Bug] Prince of Wesnoth freezes

[Belfaldurnik]

Steam release of the game. 1.18.0 as of 2024-04-25. Windows 10.

Savegame attached. Can you reproduce it?

I've completed a couple of campaigns, but deep into Delfador's Memoirs, the "Prince of Wesnoth" scenario freezes during the introduction. Always. No matter whether I end the previous scenario or if I reload the save file. Pressing "Skip" makes it freeze. Music continues, but that's all. Or pressing the "->" button to show the individual screens, it freezes on the last screen.

[gnombat]

Savegame attached. Can you reproduce it?

I can reproduce it, although if I wait about a minute or so, eventually the scenario does continue. Very strange.

[Belfaldurnik]

Cool. I've waited for seemingly a minute as well before hitting ESC and quitting.

From pressing "Skip" it takes 52 seconds with an i7-something CPU and also on an i5-something. There's not high processing activity though. Strange indeed.

[Soliton]

Guessing from log output it's https://github.com/wesnoth/wesnoth/blob ... #L501-L579
which is run in a prestart event. Looks like that unstores a bunch of units, modifies them and puts them into the recall list. Presumably that can be sped up a lot. Would be cool if someone can look into that for 1.18. I think for 1.19 this is going to get replaced.

[gnombat]

Could it just call units[i]:advance(false) instead of units[i]:advance( )?

LuaAPI/wesnoth/units#wesnoth.units.advance