Wesnoth on Irix

[markh]

Hi all,

this is my first post on this forum, but I have been playing the BeOS version of Wesnoth for quite a while and I like the game very much.
Besides a PC with BeOS on it, I also have an Irix machine at home.
I decided to try and get Wesnoth to compile on this machine and checked out a copy of the source through cvs, but I ran into some problems.

I'm not sure if this is the right part of the forum to discuss these kind of problems. I hope it is ok to post it here.

The problems (compiler error messages) I ran into were:

cc-1401 CC: WARNING File = builder.hpp, Line = 53
A qualified name is not allowed in a member declaration.

bool terrain_builder::update_animation(const gamemap::location &loc);

I solved this one by removing the terrain_builder:: part of the line.

cc-1079 CC: ERROR File = display.hpp, Line = 58
A type specifier is expected.

const config& config, const config& level);

I changed the variable name config to cfg (same as in the display.cpp file).

cc-1265 CC: ERROR File = help.cpp, Line = 1449
"menu" is not a nonstatic data member or base class of class "help::help_menu".

: menu(disp, empty_string_vector, false, max_height),

I added gui:: in front of menu. This error occurs a number of times in this file. All the same problem.
In this same file, there also was an error with the select_topic_internal function, but the code (the find function call) looks fine to me. I rewrote it to use a for loop like the second part of the code and it seems to work fine, but I will have to look into why the original code causes an error on Irix.

There was also a weird conflict of the function locale() of the class preferences with some header on the system (/usr/include/CC/ios). I changed the locale() function of preferences to get_locale() and everything seems to work fine then.
The last problem I had was that the link line was missing the X11 and m librariies. I'm no good with makefiles, so I don't know what caused that. I added them manually in the makefile and then Wesnoth compiles correctly.

After making the changes mentioned above, Wesnoth compiles and runs on my Irix machine.
I tried a few turns of the heir to the throne campaign and everything seems fine, although it is a bit slow. I still have to try compiling with optimizations turned on.

I'm hoping some of these changes can be added to the official source, but I haven't tested this on a different system, so I don't know how my changes would affect other systems.
Also, the changes look fine to me, but perhaps someone else has a problem with them.

[Dave]

Hi Mark,

Cool to hear that you got Wesnoth working on Irix

The changes you mention look innocuous to me. Silene, one of the developers, tells me he is going to start working on integrating them into the code.

Cheers,

David

[silene]

I also have an Irix machine at home.
I decided to try and get Wesnoth to compile on this machine and checked out a copy of the source through cvs, but I ran into some problems.

Thanks for your work. The three errors you quoted are Irix compiler defects, but as you said the fixes are trivial (and could even be considered to enhance the readability of the code), so they are now in CVS.

cc-1265 CC: ERROR File = help.cpp, Line = 1449
"menu" is not a nonstatic data member or base class of class "help::help_menu".

: menu(disp, empty_string_vector, false, max_height),

I added gui:: in front of menu. This error occurs a number of times in this file. All the same problem.

Hmmm... this was the only occurrence of a naked base class initializer I found in this file. So the other errors must be slightly different, could you point them out?

There was also a weird conflict of the function locale() of the class preferences with some header on the system (/usr/include/CC/ios). I changed the locale() function of preferences to get_locale() and everything seems to work fine then.

This fix is a bit annoying since it would break some syntaxic conventions on Wesnoth code. Such breakage is not sufficient to prevent me from implementing it, but I would be glad if you could take another look at it, and see if the name change could be avoided.

The last problem I had was that the link line was missing the X11 and m libraries. I'm no good with makefiles, so I don't know what caused that. I added them manually in the makefile and then Wesnoth compiles correctly.

It's common the X11 and m libraries are missing from the command line, because they are not strictly needed. Or at least it seems they are not on anything except Irix. It will require some autoconf/automake voodoo magic to make it works. Unfortunately I can't help you on that. Your best bet is probably to look at another autoconf-managed software that does link with X11 and m on Irix, and see how it differs from Wesnoth. The important parts are the configure.ac file (grep for X11 and the like), and the end of the src/Makefile.am file. Sorry for not being more helpful.

[markh]

Hi,

thank you for including the fixes. That should make it easier for me to keep Wesnoth compiling on Irix.

It isi certainly possible the problems I encountered were Irix compiler problems. I have an older version of the compiler. Unfortunately, I don't have access to the newer version, so I will have to make do with this one for now.

The other errors concerning the menu code look like this:

cc-3168 CC: ERROR File = help.cpp, Line = 1497
A name followed by "::" must be a class or namespace name.

to_show << pad_string << char(menu::IMG_TEXT_SEPARATOR) << "&" ;

I believe the Irix compiler wants to have the gui namespace in front of every menu occurence.
It might be fixable as well by indicating that everything from the gui namespace can be used directly (with the using declaration), but I haven't tried that yet.

I will have a look at the exact cause of the locale problem. I will probably have to ask some Irix guys who are better at this stuff than me, so this might take me some time to figure out. Same for the makefile problem. I'm no good at those things.

[silene]

I believe the Irix compiler wants to have the gui namespace in front of every menu occurence.

Done.

[Joerg]

Hello,
i have testest wesnoth 0.8.8 and also latest cvs version. But i stuck on the same error.

Code: Select all

CC -DHAVE_CONFIG_H -I. -I. -I..   -I/usr/nekoware/include -I/usr/nekoware/includ
e/SDL -D_SGI_MP_SOURCE -DWESNOTH_PATH=\"/usr/local/share/wesnoth\" -O3 -mips4 -I
/usr/nekoware/include -OPT:Olimit=0:roundoff=3  -TARG:platform=IP27:proc=r10000
-D_X11   -c -o help.o `test -f 'help.cpp' || echo './'`help.cpp
cc-1401 CC: WARNING File = builder.hpp, Line = 116
  A qualified name is not allowed in a member declaration.

        void terrain_builder::add_images_from_config(imagelist &images, const co
nfig &cfg);
             ^

cc-1001 CC: WARNING File = array.hpp, Line = 54
  The source file does not end with a new-line character.

  #endif
        ^

cc-3303 CC: WARNING File = widgets/widget.hpp, Line = 45
  A type qualifier on a return type is meaningless.

        const bool dirty() const;
                   ^

cc-3624 CC: WARNING File = widgets/button.hpp, Line = 51
  function "events::handler::process()" is hidden by "gui::button::process" --
          virtual function override intended?

        bool process(int mousex, int mousey, bool button);
             ^

cc-3624 CC: WARNING File = widgets/menu.hpp, Line = 59
  function "events::handler::process()" is hidden by "gui::menu::process" --
          virtual function override intended?

        int process(int x, int y, bool button,bool up_arrow,bool down_arrow,
            ^

cc-3624 CC: WARNING File = help.hpp, Line = 107
  function "events::handler::process()" is hidden by "help::help_menu::process"
          -- virtual function override intended?

        int process(int x, int y, bool button,bool up_arrow,bool down_arrow,
            ^

cc-3554 CC: WARNING File = /usr/nekoware/include/SDL/SDL_net.h, Line = 263
  use of a type with no linkage to declare a function

  extern DECLSPEC int SDLCALL SDLNet_AddSocket(SDLNet_SocketSet set, SDLNet_Gene
ricSocket sock);
                              ^

cc-3554 CC: WARNING File = /usr/nekoware/include/SDL/SDL_net.h, Line = 270
  use of a type with no linkage to declare a function

  extern DECLSPEC int SDLCALL SDLNet_DelSocket(SDLNet_SocketSet set, SDLNet_Gene
ricSocket sock);
                              ^

cc-1323 CC: ERROR File = /usr/include/CC/stl_algo.h, Line = 94
  No operator "!=" matches these operands.

            The operand types are:  const help::topic != const help::topic.
    while (__first != __last && *__first != __val)
                                         ^
          A template was detected during header processing.
            instantiation of "std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>
                      std::__find(std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>,
                      std::_List_iterator<help::topic, const help::topic &,
                      const help::topic *>, const help::topic &,
                      std::input_iterator_tag)" at line 194
            instantiation of "std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>
                      std::find(std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>,
                      std::_List_iterator<help::topic, const help::topic &,
                      const help::topic *>, const help::topic &)" at line 839
                      of "help.cpp"

cc-1174 CC: WARNING File = help.cpp, Line = 47
  The variable "<unnamed>::menu_font_size" was declared but never referenced.

        const int menu_font_size = 14;
                  ^

cc-1174 CC: WARNING File = help.cpp, Line = 86
  The function "<unnamed>::about_text_formatter::operator()" was declared but
          never referenced.

                std::string operator()(const std::string &s) {
                            ^

1 error detected in the compilation of "help.cpp".
gmake[3]: *** [help.o] Error 2
gmake[3]: Leaving directory `/raids/strip2/MIPS/wesnoth-0.8/src'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/raids/strip2/MIPS/wesnoth-0.8/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/raids/strip2/MIPS/wesnoth-0.8'
gmake: *** [all] Error 2
[o2k]:/usr2/MIPS/wesnoth-0.8 $

Mips CC Version 7.4.2 on IRIX 6.5.26.

maybe someone can help me on this.

regards
Joerg

[silene]

Hello,
i have testest wesnoth 0.8.8 and also latest cvs version. But i stuck on the same error.

Code: Select all

cc-1323 CC: ERROR File = /usr/include/CC/stl_algo.h, Line = 94
  No operator "!=" matches these operands.

            The operand types are:  const help::topic != const help::topic.
    while (__first != __last && *__first != __val)
                                         ^
          A template was detected during header processing.
            instantiation of "std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>
                      std::__find(std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>,
                      std::_List_iterator<help::topic, const help::topic &,
                      const help::topic *>, const help::topic &,
                      std::input_iterator_tag)" at line 194
            instantiation of "std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>
                      std::find(std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>,
                      std::_List_iterator<help::topic, const help::topic &,
                      const help::topic *>, const help::topic &)" at line 839
                      of "help.cpp"

Hmmm... I don't know what you tested, but the warning messages you pasted are clearly not from 0.8.8 or CVS. Probably 0.8.7 or older. Anyway, your compilation error would probably still occur with latest Wesnoth. So I have committed a workaround to CVS. I don't have any way to test if it will work though.

[Joerg]

Hello,
i have testest wesnoth 0.8.8 and also latest cvs version. But i stuck on the same error.

Code: Select all

cc-1323 CC: ERROR File = /usr/include/CC/stl_algo.h, Line = 94
  No operator "!=" matches these operands.

            The operand types are:  const help::topic != const help::topic.
    while (__first != __last && *__first != __val)
                                         ^
          A template was detected during header processing.
            instantiation of "std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>
                      std::__find(std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>,
                      std::_List_iterator<help::topic, const help::topic &,
                      const help::topic *>, const help::topic &,
                      std::input_iterator_tag)" at line 194
            instantiation of "std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>
                      std::find(std::_List_iterator<help::topic, const
                      help::topic &, const help::topic *>,
                      std::_List_iterator<help::topic, const help::topic &,
                      const help::topic *>, const help::topic &)" at line 839
                      of "help.cpp"

Hmmm... I don't know what you tested, but the warning messages you pasted are clearly not from 0.8.8 or CVS. Probably 0.8.7 or older. Anyway, your compilation error would probably still occur with latest Wesnoth. So I have committed a workaround to CVS. I don't have any way to test if it will work though.

Yes youre right it was a older version. I have picked up the link for the stable version instead of the one for 0.8.8. After a cvs update the error in help.cpp was solved. THX!

Code: Select all

cc-1020 CC: ERROR File = mapgen.cpp, Line = 136
  The identifier "sqrt" is undefined.

                        const size_t dist = size_t(sqrt(double(diffx*diffx + diffy*diffy)));
                                                   ^

cc-1020 CC: ERROR File = mapgen.cpp, Line = 152
  The identifier "sqrt" is undefined.

                                const int height = radius - int(sqrt(double(xdiff*xdiff + ydiff*ydiff)));
                                                                ^

2 errors detected in the compilation of "mapgen.cpp".

I have included math.h in mapgen.cpp to fix this. But now it stops at

Code: Select all

cc-1113 CC: ERROR File = multiplayer_client.cpp, Line = 22
  The function "<unnamed>::gamelist_manager::~gamelist_manager" was referenced
          but not defined.

  class gamelist_manager : public gui::dialog_action
        ^

1 error detected in the compilation of "multiplayer_client.cpp".
gmake[3]: *** [multiplayer_client.o] Error 2
gmake[3]: Leaving directory `/usr/people/beh/wesnoth/src'

regards
Joerg

[silene]

Code: Select all

cc-1020 CC: ERROR File = mapgen.cpp, Line = 136
  The identifier "sqrt" is undefined.

                        const size_t dist = size_t(sqrt(double(diffx*diffx + diffy*diffy)));
                                                   ^

cc-1020 CC: ERROR File = mapgen.cpp, Line = 152
  The identifier "sqrt" is undefined.

                                const int height = radius - int(sqrt(double(xdiff*xdiff + ydiff*ydiff)));
                                                                ^

2 errors detected in the compilation of "mapgen.cpp".

I have included math.h in mapgen.cpp to fix this.

I don't think it is the correct fix, since cmath is already included. Could you please try replacing "sqrt" by "std::sqrt" in mapgen.cpp and report if it does fix the problem?

But now it stops at

Code: Select all

cc-1113 CC: ERROR File = multiplayer_client.cpp, Line = 22
  The function "<unnamed>::gamelist_manager::~gamelist_manager" was referenced
          but not defined.

  class gamelist_manager : public gui::dialog_action
        ^

1 error detected in the compilation of "multiplayer_client.cpp".

I don't understand what this message is supposed to mean, I would say it's a compiler bug. Could you please try adding this line around multiplayer_client.cpp:37?

Code: Select all

~gamelist_manager() {}

[Joerg]

[quote="silene]
I don't think it is the correct fix, since cmath is already included. Could you please try replacing "sqrt" by "std::sqrt" in mapgen.cpp and report if it does fix the problem?
[/quote]

This looks like the right way and it compiles fine.

[quote="silene]
I don't understand what this message is supposed to mean, I would say it's a compiler bug. Could you please try adding this line around multiplayer_client.cpp:37?

Code: Select all

~gamelist_manager() {}

[/quote]

Ok.. after insert in line 37 it compiles and bailed out at

Code: Select all

cc-1020 CC: ERROR File = sdl_utils.cpp, Line = 189
  The identifier "floor" is undefined.

                                        const double xsize = minimum<double>(floor(xloc+1.0)-xloc,xsrc+xratio-xloc);
                                                                             ^

1 error detected in the compilation of "sdl_utils.cpp".

I have change it to std::floor and same in line 194.

But now at the end

Code: Select all

cc-1239 CC: ERROR File = /usr/include/CC/stl_locale.h, Line = 158
  "locale" is ambiguous.

  template <class _Facet> inline const _Facet& use_facet(const locale& __loc)
                                                               ^
          A template was detected during header processing.
             instantiation of "std::use_facet" based on template argument
                      <std::ctype<char>> at line 2086 of
                      "/usr/include/CC/string".
            instantiation of "std::basic_istream<char, std::char_traits<char>>
                      &std::operator>>(std::basic_istream<char,
                      std::char_traits<char>> &, std::basic_string<char,
                      std::char_traits<char>, std::allocator<char>> &)" at
                      line 57 of "util.hpp"
            instantiation of "std::string lexical_cast(int)"

cc-1239 CC: ERROR File = /usr/include/CC/ios, Line = 484
  "locale" is ambiguous.

    locale __tmp = ios_base::imbue(__loc);
[...]
14 errors detected in the compilation of "preferences.cpp".
C++ prelinker: Error compiling preferences.o
gmake[3]: *** [wesnoth] 

regard
Joerg

[silene]

I don't think it is the correct fix, since cmath is already included. Could you please try replacing "sqrt" by "std::sqrt" in mapgen.cpp and report if it does fix the problem?

This looks like the right way and it compiles fine.

I applied it to sqrt and floor functions then.

But now at the end

Code: Select all

cc-1239 CC: ERROR File = /usr/include/CC/stl_locale.h, Line = 158
  "locale" is ambiguous.

  template <class _Facet> inline const _Facet& use_facet(const locale& __loc)
                                                               ^
          A template was detected during header processing.
             instantiation of "std::use_facet" based on template argument
                      <std::ctype<char>> at line 2086 of
                      "/usr/include/CC/string".
            instantiation of "std::basic_istream<char, std::char_traits<char>>
                      &std::operator>>(std::basic_istream<char,
                      std::char_traits<char>> &, std::basic_string<char,
                      std::char_traits<char>, std::allocator<char>> &)" at
                      line 57 of "util.hpp"
            instantiation of "std::string lexical_cast(int)"

cc-1239 CC: ERROR File = /usr/include/CC/ios, Line = 484
  "locale" is ambiguous.

    locale __tmp = ios_base::imbue(__loc);
[...]
14 errors detected in the compilation of "preferences.cpp".
C++ prelinker: Error compiling preferences.o

That's annoying, it's the same problem markh was encountering. Irix system headers seem like a pain. I may have to modify Wesnoth source to workaround this issue. But not today, it's getting late. If you want to try go further with the compilation, you can replace the three occurences of "locale()" (language.cpp, preferences.cpp, preferences.hpp) by another name, since it seemed to fix the problem for markh.

[silene]

If you want to try go further with the compilation, you can replace the three occurences of "locale()" (language.cpp, preferences.cpp, preferences.hpp) by another name, since it seemed to fix the problem for markh.

I finally committed such a change. Let's hope that IRIX headers are not using "language" as bad as "locale"...

[Joerg]

If you want to try go further with the compilation, you can replace the three occurences of "locale()" (language.cpp, preferences.cpp, preferences.hpp) by another name, since it seemed to fix the problem for markh.

I finally committed such a change. Let's hope that IRIX headers are not using "language" as bad as "locale"...

Thx a lot!. It now compiles without renaming the function by hand. I played the tutorial and click on every button i found in the game and it runs fine. A note about the missing -lX11. A workaround with $LDFLAGS dont work because the libs are added in front of the link line and not at the end after the -o.


When starts compiling with --enable-server its stumble across a similar error like above.

Code: Select all

CC -I/usr/nekoware/include/SDL -D_SGI_MP_SOURCE -DLOCALEDIR="translations" -O3 -mips4 -Wl,-rpath -Wl,/usr/nekoware/lib -I/usr/nekoware/include -OPT:Olimit=0:roundoff=3  -TARG:platform=IP27:proc=r10000 -L/usr/nekoware/lib -lSDL -lpthread -lSDL_net -L/usr/nekoware/lib -rpath /usr/nekoware/lib -o wesnothd  game.o input_stream.o metrics.o player.o server.o variable.o config.o filesystem.o game_config.o gettext.o log.o network.o network_worker.o thread.o  -lX11
ld32: WARNING 84 : /usr/nekoware/lib/libSDL.so is not used for resolving any symbol.
ld32: WARNING 84 : /usr/nekoware/lib/libSDL_net.so is not used for resolving any symbol.
ld32: ERROR   33 : Unresolved text symbol "SDL_Delay" -- 1st referenced by server.o.
        Use linker option -v to see when and which objects, archives and dsos are loaded.
[and so on ..]
ld32: ERROR   33 : Unresolved text symbol "libintl_bindtextdomain" -- 1st referenced by config.o.

A add the missing libs to the end and toogle also the order to match fine.

Code: Select all

CC -I/usr/nekoware/include/SDL -D_SGI_MP_SOURCE -DLOCALEDIR="translations" -O3 -mips4 -Wl,-rpath -Wl,/usr/nekoware/lib -I/usr/nekoware/include -OPT:Olimit=0:roundoff=3  -TARG:platform=IP27:proc=r10000 -L/usr/nekoware/lib  -L/usr/nekoware/lib -rpath /usr/nekoware/lib -o wesnothd  game.o input_stream.o metrics.o player.o server.o variable.o config.o filesystem.o game_config.o gettext.o log.o network.o network_worker.o thread.o  -lSDL -lpthread -lSDL_net -lintl -lX11

But in the end one is still missing.

Code: Select all

ld32: ERROR   33 : Unresolved text symbol "image::locator::locator(const image::locator&)" -- 1st referenced by variable.o.

Which lib contains these symbol? Using grep and nm $i doesnt find one.

regards
Joerg

[silene]

Thx a lot!. It now compiles without renaming the function by hand. I played the tutorial and click on every button i found in the game and it runs fine.

Great.

A note about the missing -lX11. A workaround with $LDFLAGS dont work because the libs are added in front of the link line and not at the end after the -o.

$LDFLAGS is for flags, and hence at the front. $LDLIBS is for libraries.

I add the missing libs to the end and toogle also the order to match fine.

You mean that not only -lX11, but also -lintl was missing from the link? It is missing only during server compilation, not during game compilation?

But in the end one is still missing.

Code: Select all

ld32: ERROR   33 : Unresolved text symbol "image::locator::locator(const image::locator&)" -- 1st referenced by variable.o.

Which lib contains these symbol? Using grep and nm $i doesnt find one.

It is located in image.o (compiled from image.cpp). Are you still speaking about the server compilation?

[Joerg]

A note about the missing -lX11. A workaround with $LDFLAGS dont work because the libs are added in front of the link line and not at the end after the -o.

$LDFLAGS is for flags, and hence at the front. $LDLIBS is for libraries.

Ah ok.. i'll test it again then.

I add the missing libs to the end and toogle also the order to match fine.

You mean that not only -lX11, but also -lintl was missing from the link? It is missing only during server compilation, not during game compilation?

-lX11 was already there and yes -lintl was missing when speaking about wesnoth/src/server now.

But in the end one is still missing.

Code: Select all

ld32: ERROR   33 : Unresolved text symbol "image::locator::locator(const image::locator&)" -- 1st referenced by variable.o.

Which lib contains these symbol? Using grep and nm $i doesnt find one.

It is located in image.o (compiled from image.cpp). Are you still speaking about the server compilation?

Yes i mean the server part now.